Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue_792 catch warcio exception #793

Conversation

oskarhek
Copy link
Contributor

@oskarhek oskarhek commented Jan 3, 2023

stop auto indexing from crashing when warc records can't be indexed

Description

catch the exception, log the error

Motivation and Context

autoindeling continues

Types of changes

  • Replay fix (fixes a replay specific issue)
  • [X ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added or updated tests to cover my changes.
  • All new and existing tests passed.

@tw4l
Copy link
Member

tw4l commented Jan 5, 2023

Connected to #792

Thank you for the issue and PR @oskarhek! 🙌 LGTM, merging into main and we'll include this in the next patch release.

@tw4l tw4l merged commit 3050fd2 into webrecorder:main Jan 5, 2023
@oskarhek oskarhek deleted the issue_792_autoindexing_stops_working_on_exception branch January 6, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants