Make filter expressions translatable #783
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add some more strings for translation by moving them from javascript files to the corresponding HTML templates
Also make pressing enter in the filtering expression field less surprising by adding a new filter instead of submitting the search without the filter being created. If no new filter is being created fall back to the previous behavior of submitting the form.
Motivation and Context
All strings should be translatable to avoid annoying language mix ups. This PR fixes the remaining strings in
query.js
andsearch.js
.Screenshots (if appropriate):
The query page where
Filtering by
andContains
et al. were previously not translatable:Types of changes
Checklist: