Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make filter expressions translatable #783

Merged
merged 2 commits into from
Dec 6, 2022
Merged

Conversation

krakan
Copy link
Contributor

@krakan krakan commented Dec 6, 2022

Description

Add some more strings for translation by moving them from javascript files to the corresponding HTML templates
Also make pressing enter in the filtering expression field less surprising by adding a new filter instead of submitting the search without the filter being created. If no new filter is being created fall back to the previous behavior of submitting the form.

Motivation and Context

All strings should be translatable to avoid annoying language mix ups. This PR fixes the remaining strings in query.js and search.js.

Screenshots (if appropriate):

The query page where Filtering by and Contains et al. were previously not translatable:
2022-12-06-145945_1151x375_scrot
2022-12-06-150010_1154x378_scrot

Types of changes

  • Replay fix (fixes a replay specific issue)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added or updated tests to cover my changes.
  • All new and existing tests passed.

@tw4l tw4l self-requested a review December 6, 2022 17:25
Copy link
Member

@tw4l tw4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you @krakan! And for the screenshots as well :)

@tw4l tw4l merged commit de5806c into webrecorder:2.7.1-dev Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants