Rewrite: Support target rewriting, open new windows in top-frame instead #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tw4l
changed the title
tw4l
added a commit
that referenced
this pull request
Oct 19, 2022
…ead (#767) * Bump wombat to 3.3.9 * Set target attributes to iframe name
tw4l
added a commit
that referenced
this pull request
Nov 17, 2022
…ead (#767) * Bump wombat to 3.3.9 * Set target attributes to iframe name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This ports webrecorder/wabac.js#84 to work in pywb, forcing tags with targets to update the top replay frame.
Motivation and Context
Tags with a target of
_blank,_top, or_parentwere causing issues with replay where new iframes were nested within the existing replay iframe rather than updating it. They also have the potential to open new windows, causing unexpected behaviour.This was pointed out by Lauren Ko on the site https://cybercemetery.unt.edu/thenamingcommission/20220922214652/https://www.thenamingcommission.gov/
Resolves #766
Related to webrecorder/wombat#94
Types of changes
Checklist: