Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing translation for the filter-epression field placeholder #721

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

krakan
Copy link
Contributor

@krakan krakan commented May 17, 2022

Description

Add the {% trans %}/{% endtrans %} tags for the placeholder text of the filter-expression field on the search.html page.

Motivation and Context

Needed in order for translators to be able to translate it to other languages.

Screenshots (if appropriate):

2022-05-17-152014_1190x565_scrot
2022-05-17-152735_1146x558_scrot

Types of changes

  • Replay fix (fixes a replay specific issue)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added or updated tests to cover my changes.
  • All new and existing tests passed.

The tests/test_auto_colls.py::TestManagedColls::test_add_static test is failing with and without this change. The other 807 tests passed.

@ikreymer ikreymer merged commit 4ac580e into webrecorder:main Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants