More consistent env var setting / static path fix #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ensure pywb.static_prefix includes pywb.app_prefix (via SCRIPT_NAME) for non replay templates, fixes #686
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensure the
pywb.app_path,pywb.host_pathandpywb.static_pathare set for all templates, including replayand non-replay templates.
Also ensure the X-Forwarded-Proto is accounted for.
Update to latest wombat (3.3.6)
bump version to 2.6.3
Motivation and Context
Fixes #686 , regression is 2.6.2
Screenshots (if appropriate):
Types of changes
Checklist: