Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zipnum index: fail if counting pages with filter params #631

Conversation

sebastian-nagel
Copy link
Contributor

Description

Do not apply any filters (param filter, from, to, closest) if counting pages (param showNumPages=true) to avoid that the CDX filter/processing fails if it tries to read keys not present in a page-count result.

Motivation and Context

Avoid error responses "HTTP 500 Internal Error: 'urlkey'" (also 'url' or 'timestamp') which are not helpful.

Ev., could also argue to turn these into bad request responses. The solution here tries to be backward-compatible to PyWB 0.33.2 where filter params are simply ignored.

Types of changes

  • Replay fix (fixes a replay specific issue)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added or updated tests to cover my changes.
  • All new and existing tests passed.

- do not apply any filters (param filter, from, to, closest)
  if counting pages (param showNumPages=true)
@ikreymer
Copy link
Member

Makes sense. The pageCount never did take into account any other filters, so probably ok to ignore to be compatible.

@ikreymer ikreymer merged commit 73d6735 into webrecorder:master Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants