Zipnum index: fail if counting pages with filter params #631
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Do not apply any filters (param filter, from, to, closest) if counting pages (param showNumPages=true) to avoid that the CDX filter/processing fails if it tries to read keys not present in a page-count result.
Motivation and Context
Avoid error responses "HTTP 500 Internal Error: 'urlkey'" (also 'url' or 'timestamp') which are not helpful.
Ev., could also argue to turn these into bad request responses. The solution here tries to be backward-compatible to PyWB 0.33.2 where filter params are simply ignored.
Types of changes
Checklist: