FrontendApp: forward HTTP status of CDX backend #624
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The patch makes FrontendApp forward the HTTP status of the CDX backend, so that clients can handle errors properly.
Motivation and Context
If the CDX backend fails to process a query, the FrontendApp still responds with HTTP status
200 OK
. The (error) status (eg. "400 Bad request", "404 Not found", etc.) should be passed forward to the client.A clear HTTP error simplifies the processing of the CDX results in the client. The fix also ensures that the CDXJ API is compatibility with the behavior of the API in PyWB 0.33.2.
One example to reproduce the issue:
...&output=foo
){"message": "output=foo not supported"}
With the patch applied the response status will be
400 Bad Request output=foo not supported
, the response body is unchanged.Types of changes
Checklist: