IndexHandler: backward-compatibility for fl (fields) param
#621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While CDXQuery supports the old query parameter
fl(query.py#L88), the class IndexHandler does not,Description
The PR add backward-compatibility support for the query parameter
fl(in addition to the paramfields).Motivation and Context
The change is part of an effort to upgrade Common Crawl's CDX server to the recent version of PyWB while ensuring 100% API compatibility (see commoncrawl/cc-index-server#8). Teaching the users a new API and upgrading all clients in the wild seems impossible as there are too many.