Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pending request count in pywb to ensure all requests written to WARC before terminating #44

Closed
ikreymer opened this issue Apr 15, 2021 · 0 comments · Fixed by #47
Closed

Add pending request count in pywb to ensure all requests written to WARC before terminating #44

ikreymer opened this issue Apr 15, 2021 · 0 comments · Fixed by #47
Assignees
@ikreymer

Comments

@ikreymer
Copy link
Member

Instead of the 5s wait for WARCs at the end, add actual counter to pywb to track pending requests and wait until all are done.
This should help with instances where a large video is being streamed, and page timeout may have exceeded, but still need to wait for full video to load and be written to WARC.
@ikreymer ikreymer self-assigned this Apr 15, 2021
ikreymer added a commit that referenced this issue Apr 28, 2021
@ikreymer
pending request wait:
8efd89b 
- instead of waiting for 5s, check redis key 'pywb:{coll}:pending' to see if any pending requests are still pending
- keep checking key until pending requests are at 0
- requires latest pywb 2.6.0+
- should fix #44
@ikreymer ikreymer mentioned this issue Apr 28, 2021
Merged
8 tasks
ikreymer added a commit that referenced this issue Apr 29, 2021
@ikreymer
pending request wait:
3beb3da 
- instead of waiting for 5s, check redis key 'pywb:{coll}:pending' to see if any pending requests are still pending
- keep checking key until pending requests are at 0
- requires latest pywb 2.6.0+
- should fix #44
@ikreymer ikreymer mentioned this issue Apr 29, 2021
Merged
emmadickson pushed a commit that referenced this issue Apr 30, 2021
@ikreymer
Wait for Pending Requests to Finish (#47)
183f8ed 
* pending request wait:
- instead of waiting for 5s, check redis key 'pywb:{coll}:pending' to see if any pending requests are still pending
- keep checking key until pending requests are at 0
- requires latest pywb 2.6.0+
- should fix #44

* fix test to no longer look for waiting for 5s message

* lint settings and fixes: allow constant in loops, add lint command to script

* chrome: bump default image to chrome:90 image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ikreymer ikreymer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Wait for Pending Requests to Finish webrecorder/browsertrix-crawler
1 participant
@ikreymer