Always run config resolver #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
This was referenced Dec 20, 2024
|
Thanks! Appreciate the thoroughness. Not even sure why I didn't do it yet, but it's good to enforce more correctness/strictness in |
|
🚀 This pull request is included in v5.42.0. See Release 5.42.0 for release notes. Using Knip in a commercial project? Please consider becoming a sponsor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading Knip to latest version 5.41.1 from 5.38.2 in an Angular project found out that a file that was previously correctly tracked as production entry was suddenly appearing as unused file (specifically,
src/main.ts) when using knip in production mode. I've been working with the Angular plugin recently, so first thought was I may have messed up something. That file is added as production entry because appears inbrowseroption of thebuildtarget inangular.json.However, that piece of code hasn't changed and the file should be added as production entry. After manually bisecting which version introduced the bug, seems it appears in 5.39.2. In there, there's a plugin housekeeping commit that removes the empty
productionarray from the plugin. However, due to a check when running plugins, theresolveConfigfunction won't be executed when running in production mode if noproductionkey is present in the plugin. Hence when removing that emptyproductionarray from the Angular plugin, theresolveConfigfunction wasn't ran and the production entrysrc/main.tswasn't added.Given the issue, I could have brought back the
productionempty array to the Angular plugin. However, I think that it's better to always run theresolveConfigfunction if is defined. Both in production and non-production modes. Because several plugins actually use thetoProductionEntryfunction as part ofresolveConfig. So this issue could happen in the case thatproductionkey is removed and all production entries are added as part ofresolveConfig. Let me know if there's something else I may be missing though!