Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title for vote page #746

Closed
wants to merge 3 commits into from
Closed

Conversation

pllearns
Copy link

@pllearns pllearns commented Jan 28, 2017

  1. Created Title for page "Voting and Influence" - any suggestions are welcome.
  2. Styled the title to the vote page.
    Fixes Dev - Title Missing on Voting Page #720

@jsf-clabot
Copy link

jsf-clabot commented Jan 28, 2017

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ pllearns
❌ Phillip Lorenzo


Phillip Lorenzo, pllearns seem not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@bebraw
Copy link
Contributor

bebraw commented Jan 28, 2017

Can you split this into two PRs so that the styling bit goes to its own? Easier to review/merge. There's also some CLA issue (probably committed from different accounts). Thanks.

@johnstew
Copy link

Having the styling bit on its own would be easier to review/merge. Also my original ticket was in reference to the actual HTML title of the page.

Right now it looks like this.

screen shot 2017-01-28 at 12 31 55 pm

That title for the page should match what you have in your styled title that you added to the page.

@pllearns
Copy link
Author

Thanks for the feedback. I'll take care of this tomorrow.

@pllearns
Copy link
Author

Hey, I will be closing this PR and resubmitting with separate PRs.

@pllearns pllearns closed this Jan 29, 2017
@pllearns pllearns deleted the title-for-vote-page branch January 29, 2017 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants