Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(guides): refine code-splitting code snippets #6279

Merged
merged 2 commits into from
Jul 19, 2022
Merged

docs(guides): refine code-splitting code snippets #6279

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03aeb82
Update code-splitting.mdx
Matin297 Jul 16, 2022
62e522a
update code-splitting.mdx
Matin297 Jul 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/content/guides/code-splitting.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ Now, instead of statically importing `lodash`, we'll use dynamic importing to se
-
-function component() {
+function getComponent() {
const element = document.createElement('div');
- const element = document.createElement('div');

- // Lodash, now imported by this script
- element.innerHTML = _.join(['Hello', 'webpack'], ' ');
Expand Down Expand Up @@ -359,7 +359,7 @@ As `import()` returns a promise, it can be used with [`async` functions](https:/
```diff
-function getComponent() {
+async function getComponent() {
const element = document.createElement('div');
+ const element = document.createElement('div');
+ const { default: _ } = await import('lodash');

- return import('lodash')
Expand Down