Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(all): add doctype for valid HTML in all documentation #1868

Merged
merged 4 commits into from
Mar 1, 2018
Merged

docs(all): add doctype for valid HTML in all documentation #1868

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
872d613
Added doctype for valid HTML
TheDutchCoder Mar 1, 2018
6f8ab97
Added more doctypes
TheDutchCoder Mar 1, 2018
fcc22eb
docs(content) Add doctype to HTML example
montogeek Mar 1, 2018
638be35
Merge branch 'master' into TheDutchCoder-patch-2
TheDutchCoder Mar 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/content/guides/asset-management.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ Let's make a minor change to our project before we get started:
__dist/index.html__

``` diff
<!doctype html>
<html>
<head>
- <title>Getting Started</title>
Expand Down
21 changes: 11 additions & 10 deletions src/content/guides/author-libraries.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,17 +101,18 @@ require(['webpackNumbers'], function ( webpackNumbers) {
The consumer also can use the library by loading it via a script tag:

``` html
<!doctype html>
<html>
...
<script src="https://unpkg.com/webpack-numbers"></script>
<script>
// ...
// Global variable
webpackNumbers.wordToNum('Five')
// Property in the window object
window.webpackNumbers.wordToNum('Five')
// ...
</script>
...
<script src="https://unpkg.com/webpack-numbers"></script>
<script>
// ...
// Global variable
webpackNumbers.wordToNum('Five')
// Property in the window object
window.webpackNumbers.wordToNum('Five')
// ...
</script>
</html>
```

Expand Down
2 changes: 1 addition & 1 deletion src/content/guides/development-vagrant.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ module.exports = {
And create a `index.html` file. The script tag should point to your bundle. If `output.filename` is not specified in the config, this will be `bundle.js`.

```html
<!DOCTYPE html>
<!doctype html>
<html>
<head>
<script src="/bundle.js" charset="utf-8"></script>
Expand Down
2 changes: 2 additions & 0 deletions src/content/guides/getting-started.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ document.body.appendChild(component());
__index.html__

``` html
<!doctype html>
<html>
<head>
<title>Getting Started</title>
Expand Down Expand Up @@ -127,6 +128,7 @@ Now, since we'll be bundling our scripts, we have to update our `index.html` fil
__dist/index.html__

``` diff
<!doctype html>
<html>
<head>
<title>Getting Started</title>
Expand Down
1 change: 1 addition & 0 deletions src/content/guides/output-management.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ Let's also update our `dist/index.html` file, in preparation for webpack to spli
__dist/index.html__

``` diff
<!doctype html>
<html>
<head>
- <title>Asset Management</title>
Expand Down
1 change: 1 addition & 0 deletions src/content/guides/shimming.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,7 @@ With that in place, we can add the logic to conditionally load our new `polyfill
__dist/index.html__

``` diff
<!doctype html>
<html>
<head>
<title>Getting Started</title>
Expand Down
1 change: 1 addition & 0 deletions src/content/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ module.exports = {
__page.html__

```html
<!doctype html>
<html>
<head>
...
Expand Down