Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document new output.devtoolNamespace option #1653

Merged
merged 2 commits into from
Dec 19, 2017
Merged

Conversation

MagicDuck
Copy link
Contributor

added docs for new output.devtoolNamespace option and [namespace] placeholder.

@jsf-clabot
Copy link

jsf-clabot commented Oct 17, 2017

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@sokra sokra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

webpack 4

`string`

This option determines the modules namespace used with the [`output.devtoolModuleFilenameTemplate`](#output-devtoolmodulefilenametemplate). When not specified, it will default to the value of: [`output.library`](#output-library). It's use is to prevent source file path collisions in sourcemaps when loading multiple libraries built with webpack.
For example, if you have 2 libraries, with namespaces `library1` and `library2`, which both have a file `./src/index.js` (with potentially different contents), they will expose these files as `webpack://library1/./src/index.js` and `webpack://library2/./src/index.js`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add another line break to split this into two paragraphs. The way markdown is processed line 162 and 163 will be joined into one.

@@ -153,6 +155,12 @@ devtoolModuleFilenameTemplate: info => {

If multiple modules would result in the same name, [`output.devtoolFallbackModuleFilenameTemplate`](#output-devtoolfallbackmodulefilenametemplate) is used instead for these modules.

## `output.devtoolNamespace`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We typically add two line breaks before h2s.

Copy link
Collaborator

@skipjack skipjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MagicDuck thanks for adding this, please see the minor formatting related comments I added.

@skipjack
Copy link
Collaborator

@sokra so we should probably hold off on this and other webpack 4 related ones that come in until it's actually release, correct?

Copy link
Collaborator

@skipjack skipjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MagicDuck thanks for making the updates.

@skipjack skipjack changed the title adding docs for new output.devtoolNamespace option Document new output.devtoolNamespace option Nov 5, 2017
@skipjack skipjack changed the base branch from master to next December 19, 2017 04:36
@skipjack
Copy link
Collaborator

Merging this and any other approved webpack 4 changes (e.g. #1754 when it's finished) to a next branch which we can merge to master when v4 is released. Prior to that merge though we should tag master at the latest 3.x version. This will put us in a good place for archiving later on.

@skipjack skipjack merged commit 549cd38 into webpack:next Dec 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants