-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document new output.devtoolNamespace
option
#1653
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
webpack 4
src/content/configuration/output.md
Outdated
`string` | ||
|
||
This option determines the modules namespace used with the [`output.devtoolModuleFilenameTemplate`](#output-devtoolmodulefilenametemplate). When not specified, it will default to the value of: [`output.library`](#output-library). It's use is to prevent source file path collisions in sourcemaps when loading multiple libraries built with webpack. | ||
For example, if you have 2 libraries, with namespaces `library1` and `library2`, which both have a file `./src/index.js` (with potentially different contents), they will expose these files as `webpack://library1/./src/index.js` and `webpack://library2/./src/index.js`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should add another line break to split this into two paragraphs. The way markdown is processed line 162 and 163 will be joined into one.
src/content/configuration/output.md
Outdated
@@ -153,6 +155,12 @@ devtoolModuleFilenameTemplate: info => { | |||
|
|||
If multiple modules would result in the same name, [`output.devtoolFallbackModuleFilenameTemplate`](#output-devtoolfallbackmodulefilenametemplate) is used instead for these modules. | |||
|
|||
## `output.devtoolNamespace` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We typically add two line breaks before h2
s.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MagicDuck thanks for adding this, please see the minor formatting related comments I added.
@sokra so we should probably hold off on this and other webpack 4 related ones that come in until it's actually release, correct? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MagicDuck thanks for making the updates.
output.devtoolNamespace
optionoutput.devtoolNamespace
option
Merging this and any other approved webpack 4 changes (e.g. #1754 when it's finished) to a |
added docs for new
output.devtoolNamespace
option and [namespace] placeholder.