Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code blocks on homepage #350

Closed
mxstbr opened this issue Nov 17, 2016 · 3 comments
Closed

Code blocks on homepage #350

mxstbr opened this issue Nov 17, 2016 · 3 comments
Labels
Enhancement UI/UX
Milestone
webpack 2 - Post-...

Comments

@mxstbr
Copy link
Collaborator

mxstbr commented Nov 17, 2016

The four code blocks on the homepage should be two in one row, instead of wasting a bunch of space:

screen shot 2016-11-17 at 18 03 09

Those code blocks could easily fit next to each other instead of having a massive amount of horizontal space, like this:

Write your code
import bar from 'foo'; export function bar()
Bundle with webpack
module.exports = {} <html>
@skipjack
Copy link
Collaborator

Good point, you'd be welcome to PR this if you're interested. Maybe the best way to go would be a flex box and have them at 50% on larger screens and 100% on mobile?

@mxstbr
Copy link
Collaborator Author

mxstbr commented Nov 18, 2016

I tried to do it, but the Markdown + HTML handling didn't work as I expected and I don't have time to dig in further. For somebody who's used to this setup, this should be a five minute operation!

@skipjack
Copy link
Collaborator

Ok, I can pick this up.

@bebraw bebraw added this to the webpack 2 Post-release Milestone milestone Nov 23, 2016
NejcZdovc added a commit to NejcZdovc/webpack.js.org that referenced this issue Dec 31, 2016
@NejcZdovc
Added split code blocks to home page
5e5bd58 
Resolves webpack#350
@NejcZdovc NejcZdovc mentioned this issue Dec 31, 2016
Merged
NejcZdovc added a commit to NejcZdovc/webpack.js.org that referenced this issue Jan 1, 2017
@NejcZdovc
Added split code blocks to home page
3b091fb 
Resolves webpack#350
NejcZdovc added a commit to NejcZdovc/webpack.js.org that referenced this issue Jan 9, 2017
@NejcZdovc
Added split code blocks to home page
4c05846 
Resolves webpack#350
bebraw added a commit that referenced this issue Jan 15, 2017
@bebraw
Merge pull request #573 from NejcZdovc/feature/#350
d568ad5 
Added split code blocks to home page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement UI/UX
Projects
None yet
Milestone
webpack 2 - Post-release Milestone
Development

No branches or pull requests
3 participants
@bebraw @mxstbr @skipjack