Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add stats:verbose to cli's webpack config #2735

Merged
merged 1 commit into from
Sep 12, 2020

Conversation

hiroppy
Copy link
Member

@hiroppy hiroppy commented Sep 12, 2020

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

updated

Motivation / Use-Case

when we use [email protected], our CI will be broken.

output logs are the difference between beta.29 and beta.30.

[email protected]

    <i> [webpack-dev-server] Project is running at http://localhost:8080/
    <i> [webpack-dev-server] webpack output is served from undefined
    <i> [webpack-dev-middleware] Hash: 44cb6417926dcafb24fe
    <i> Version: webpack 5.0.0-beta.29
    <i> Time: 267 ms
    <i> Built at: 2020-09-12 13:25:14
    <i> asset main.js 231 KiB [emitted] (name: main)
    <i> Entrypoint main = main.js
    <i> ./foo.js 41 bytes [built]
    <i> ../../../client/default/index.js?http://localhost:8080 4.4 KiB [built]
    <i> ../../../node_modules/webpack/hot/dev-server.js 1.59 KiB [built]
    <i> ../../../client/transpiled-modules/strip-ansi.js 1.4 KiB [built]
    <i> ../../../client/default/socket.js 1.27 KiB [built]
    <i> ../../../client/default/utils/log.js 414 bytes [built]
    <i> ../../../client/default/overlay.js 3.53 KiB [built]
    <i> ../../../client/default/utils/sendMessage.js 402 bytes [built]
    <i> ../../../client/default/utils/reloadApp.js 1.58 KiB [built]
    <i> ../../../node_modules/webpack/hot/emitter.js 75 bytes [built]
    <i> ../../../client/default/utils/createSocketUrl.js 2.87 KiB [built]
    <i> ../../../node_modules/webpack/hot sync nonrecursive ^\.\/log$ 170 bytes [built]
    <i> ../../../node_modules/webpack/hot/log.js 1.34 KiB [built]
    <i> ../../../node_modules/webpack/hot/log-apply-result.js 1.29 KiB [built]
    <i> ../../../client/clients/WebsocketClient.js 4.07 KiB [built]
    <i>     + 25 hidden modules
    <i> [webpack-dev-middleware] Compiled successfully.

[email protected]

    <i> [webpack-dev-server] Project is running at http://localhost:8080/
    <i> [webpack-dev-server] webpack output is served from undefined
    <i> [webpack-dev-middleware] asset main.js 231 KiB [emitted] (name: main)
    <i> runtime modules 23.8 KiB 10 modules
    <i> cacheable modules 169 KiB
    <i>   modules by path ../../../node_modules/ 122 KiB
    <i>     modules by path ../../../node_modules/webpack/hot/ 4.3 KiB 4 modules
    <i>     modules by path ../../../node_modules/html-entities/lib/ 57.9 KiB 4 modules
    <i>     modules by path ../../../node_modules/url/ 37.4 KiB 3 modules
    <i>     modules by path ../../../node_modules/querystring/ 4.51 KiB 3 modules
    <i>     2 modules
    <i>   modules by path ../../../client/ 46.6 KiB
    <i>     modules by path ../../../client/transpiled-modules/ 26.4 KiB 2 modules
    <i>     modules by path ../../../client/clients/ 5.12 KiB
    <i>       ../../../client/clients/WebsocketClient.js 4.07 KiB [built] [code generated]
    <i>       ../../../client/clients/BaseClient.js 1.04 KiB [built] [code generated]
    <i>     modules by path ../../../client/default/ 15.1 KiB
    <i>   ./foo.js 41 bytes [built] [code generated]
    <i> ../../../node_modules/webpack/hot/ sync nonrecursive ^\.\/log$ 170 bytes [built] [code generated]
    <i> webpack 5.0.0-beta.30 compiled successfully in 259 ms
    <i> [webpack-dev-middleware] Compiled successfully.

Breaking Changes

no

Additional Info

@hiroppy hiroppy changed the title chore(deps): upgrade chokidar (#2539) test: add stat:verbose to cli's webpack config Sep 12, 2020
@hiroppy hiroppy changed the title test: add stat:verbose to cli's webpack config test: add stats:verbose to cli's webpack config Sep 12, 2020
@codecov
Copy link

codecov bot commented Sep 12, 2020

Codecov Report

Merging #2735 into v4 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               v4    #2735   +/-   ##
=======================================
  Coverage   92.88%   92.88%           
=======================================
  Files          39       39           
  Lines        1308     1308           
  Branches      350      350           
=======================================
  Hits         1215     1215           
  Misses         89       89           
  Partials        4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 161e3d8...55a5f11. Read the comment docs.

@alexander-akait alexander-akait merged commit 709ce16 into v4 Sep 12, 2020
@alexander-akait alexander-akait deleted the feature/fix-webpack5 branch September 12, 2020 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants