Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAK CHANGES(cleint): rename keynames to camelCase #2734

Closed
wants to merge 1 commit into from

Conversation

hiroppy
Copy link
Member

@hiroppy hiroppy commented Sep 12, 2020

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Motivation / Use-Case

camelCase is very common in JavaScript world so I modified them from snake-case.

Breaking Changes

Yep

Additional Info

CI is broken so I'll fix it.

@codecov
Copy link

codecov bot commented Sep 12, 2020

Codecov Report

Merging #2734 into v4 will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##               v4    #2734   +/-   ##
=======================================
  Coverage   92.88%   92.88%           
=======================================
  Files          39       39           
  Lines        1308     1308           
  Branches      350      350           
=======================================
  Hits         1215     1215           
  Misses         89       89           
  Partials        4        4           
Impacted Files Coverage Δ
client-src/default/index.js 92.47% <100.00%> (ø)
lib/Server.js 96.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 709ce16...158a6be. Read the comment docs.

@hiroppy hiroppy changed the title BREAK CHANGES(cleint): rename keynames to camelCase WIP: BREAK CHANGES(cleint): rename keynames to camelCase Sep 12, 2020
@hiroppy
Copy link
Member Author

hiroppy commented Sep 12, 2020

Wait for #2734

@hiroppy hiroppy force-pushed the feature/rename-some-props branch from b6b2177 to 158a6be Compare September 13, 2020 05:13
@hiroppy hiroppy changed the title WIP: BREAK CHANGES(cleint): rename keynames to camelCase BREAK CHANGES(cleint): rename keynames to camelCase Sep 14, 2020
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It creates breaking change for other plugins/servers/etc which connect to our socket server and send messages for reloading, I think it is really unnecessary to do it, no benefits from this

@hiroppy
Copy link
Member Author

hiroppy commented Sep 15, 2020

ok

@hiroppy hiroppy closed this Sep 15, 2020
@hiroppy hiroppy deleted the feature/rename-some-props branch September 15, 2020 00:12
@alexander-akait
Copy link
Member

Anyway thanks for your work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants