fix: use find-cache-dir to temporarily store certificates #2729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojtekmaj
requested review from
alexander-akait,
hiroppy and
knagaitsev
as code owners
Codecov Report
@@ Coverage Diff @@
## v4 #2729 +/- ##
==========================================
+ Coverage 92.86% 92.88% +0.02%
==========================================
Files 39 39
Lines 1304 1308 +4
Branches 349 350 +1
==========================================
+ Hits 1211 1215 +4
Misses 89 89
Partials 4 4
Continue to review full report at Codecov.
|
|
Please send a PR to v4 branch, v3 accept only security fixes, I am with it, for webpack@5 we can use API, but we can improve it in future |
alexander-akait
approved these changes
Sep 3, 2020
hiroppy
approved these changes
Sep 8, 2020
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
No :( It's a path change, so no new tests would apply here. There also didn't seem to be any tests I could modify.
Motivation / Use-Case
This fixes HTTPS server not working properly in Yarn PnP mode due to the way the packages are stored, unless the user manually unplugs the package. By using find-cache-dir, used widely (e.g. by babel-loader, copy-webpack-plugin), we ensure that Yarn PnP will correctly handle reading and writing these certificates.
See thread under one of Yarn package manager maintainer's tweet:
https://twitter.com/wojtekmaj91/status/1300849402001739776?s=20
Breaking Changes
Theoretically, if someone used node_modules/webpack-dev-server/ssl as a place to store their certificates for webpack-dev-server to consume, they may have a problem. However, there are options to provide certificates to webpack-dev-server in a better way.