Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(status): public path appearing as 'undefined' #2728

Closed
wants to merge 1 commit into from
Closed

fix(status): public path appearing as 'undefined' #2728

wants to merge 1 commit into from

Conversation

cshawaus
Copy link

@cshawaus cshawaus commented Sep 2, 2020

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

No

Motivation / Use-Case

Instead of:

webpack output is served from undefined

The correct public path for webpack 5 will be shown:

webpack output is served from /

Breaking Changes

No

Additional Info

n/a

@jsf-clabot
Copy link

jsf-clabot commented Sep 2, 2020 •
edited
Loading

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@codecov
Copy link

codecov bot commented Sep 2, 2020 •
edited
Loading

Codecov Report

Merging #2728 (0a2a56e) into master (4ab1f21) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2728   +/-   ##
=======================================
  Coverage   93.77%   93.78%           
=======================================
  Files          34       34           
  Lines        1333     1335    +2     
  Branches      381      383    +2     
=======================================
+ Hits         1250     1252    +2     
  Misses         81       81           
  Partials        2        2
Impacted Files Coverage Δ
lib/utils/status.js 92.00% <100.00%> (+0.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ab1f21...0a2a56e. Read the comment docs.

alexander-akait
alexander-akait requested changes Sep 2, 2020
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invalid fix, please provide reproducible test repo

@cshawaus
Copy link
Author

cshawaus commented Sep 2, 2020

Invalid fix, please provide reproducible test repo

https://github.com/cshawaus/vue-3-ts-demo/tree/webpack-5

@alexander-akait
Copy link
Member

@cshawaus I will look at this in near future

@ylemkimon
Copy link
Contributor

Fixed in #2849.

@alexander-akait
Copy link
Member

@ylemkimon yep, anyway I think we should improve this, because publicPath can be auto or can be Function, maybe we should move it in plugin 🤔

@alexander-akait
Copy link
Member

Fixed in master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiroppy hiroppy Awaiting requested review from hiroppy hiroppy is a code owner

@knagaitsev knagaitsev Awaiting requested review from knagaitsev

@alexander-akait alexander-akait Awaiting requested review from alexander-akait alexander-akait is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cshawaus @jsf-clabot @alexander-akait @ylemkimon