Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): fix util.js #2686

Merged
merged 1 commit into from
Jul 27, 2020
Merged

chore(examples): fix util.js #2686

merged 1 commit into from
Jul 27, 2020

Conversation

hiroppy
Copy link
Member

@hiroppy hiroppy commented Jul 27, 2020

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

"before" feature is deprecated.

Motivation / Use-Case

Breaking Changes

Additional Info

@codecov
Copy link

codecov bot commented Jul 27, 2020

Codecov Report

Merging #2686 into v4 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               v4    #2686   +/-   ##
=======================================
  Coverage   92.85%   92.85%           
=======================================
  Files          37       37           
  Lines        1316     1316           
  Branches      354      354           
=======================================
  Hits         1222     1222           
  Misses         89       89           
  Partials        5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c616bb5...de3331b. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alexander-akait alexander-akait merged commit 2bbd36f into v4 Jul 27, 2020
@alexander-akait alexander-akait deleted the feature/modify-examples branch July 27, 2020 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants