BREAKING CHANGE: reorganize client directory #2562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v4 #2562 +/- ##
==========================================
- Coverage 93.43% 92.86% -0.57%
==========================================
Files 34 35 +1
Lines 1309 1331 +22
Branches 369 374 +5
==========================================
+ Hits 1223 1236 +13
- Misses 83 90 +7
- Partials 3 5 +2
Continue to review full report at Codecov.
|
hiroppy
requested changes
May 3, 2020
package.json
Outdated
| "build:client:clients": "babel client-src/clients --out-dir client/clients", | ||
| "build:client:index": "webpack ./client-src/default/index.js -o client/index.bundle.js --color --config client-src/default/webpack.config.js", | ||
| "build:client:sockjs": "webpack ./client-src/sockjs/index.js -o client/sockjs.bundle.js --color --config client-src/sockjs/webpack.config.js", | ||
| "build:client:index": "webpack ./client-src/default/index.js -o client/default/index.bundle.js --color --config client-src/default/webpack.config.js", |
There was a problem hiding this comment.
Can you move input/output to webpack.config.js?
|
/cc @Loonride need fix conflicts, great job! |
knagaitsev
force-pushed
the
chore/reorganize-client-dir
branch
from
135e474 to
3133bb5
Compare
hiroppy
approved these changes
May 5, 2020
alexander-akait
approved these changes
May 6, 2020
alexander-akait
pushed a commit
that referenced
this pull request
May 8, 2020
BREAKING CHANGE: the `client` now in `default` directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
N/A
Motivation / Use-Case
Reorganized client build output to match structure of
client-srcThoughts on if we should reorganize it more, or just do this and avoid major breaking changes?
Breaking Changes
Yes, reorganized client output dir
Additional Info