chore(deps): upgrade chokidar #2539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v4 #2539 +/- ##
=======================================
Coverage 93.77% 93.77%
=======================================
Files 34 34
Lines 1333 1334 +1
Branches 381 381
=======================================
+ Hits 1250 1251 +1
Misses 81 81
Partials 2 2
Continue to review full report at Codecov.
|
alexander-akait
approved these changes
Apr 25, 2020
|
/cc @hiroppy Are you here? |
hiroppy
approved these changes
Apr 26, 2020
This was referenced Apr 29, 2020
Closed
Closed
|
Can we get a new release out? |
+1, I'm effectively blocked on one of my projects until I lose the dependency on Chokidar 2. |
|
@paulmillr next week, we are very quickly working on fixes for new next release |
alexander-akait
pushed a commit
that referenced
this pull request
May 8, 2020
* chore(deps): upgrade chokidar * chore(deps): switch to promise method without async for close * chore(ci): remove node v6 * chore(deps): fix issue of closing watchers before middleware * chore(deps): upgrade chokidar to v3.4.0
|
@evilebottnawi how is the new release doing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Not yet
Motivation / Use-Case
upgrade chokidar to v3.3
Breaking Changes
chokidar doesn't support node v6
close should work the same
Additional Info
Edit: didn't see #2533 when I did this, I just applied the patch suggested there