Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix CHANGELOG. #2019

Merged
merged 1 commit into from
Jun 13, 2019
Merged

docs: Fix CHANGELOG. #2019

merged 1 commit into from
Jun 13, 2019

Conversation

numb86
Copy link
Contributor

@numb86 numb86 commented Jun 12, 2019

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Don't need.

Motivation / Use-Case

#1937 is 3.6.0, not 3.7.0.
The link to compare also seems to be wrong.

Breaking Changes

No.

Additional Info

No.

@codecov
Copy link

codecov bot commented Jun 12, 2019

Codecov Report

Merging #2019 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2019   +/-   ##
=======================================
  Coverage   92.77%   92.77%           
=======================================
  Files          29       29           
  Lines        1149     1149           
  Branches      327      327           
=======================================
  Hits         1066     1066           
  Misses         79       79           
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 303f4e9...e0d014d. Read the comment docs.

@hiroppy
Copy link
Member

hiroppy commented Jun 12, 2019

Did you modify using npm run release?

@numb86
Copy link
Contributor Author

numb86 commented Jun 12, 2019

No.
I edited CHANGELOG.md directly and committed it.
Were there any mistakes in my way?

@hiroppy
Copy link
Member

hiroppy commented Jun 12, 2019

CHANGELOG.md is generated automatically by the release command. So, if you want to modify this file, you should run this command.

@numb86
Copy link
Contributor Author

numb86 commented Jun 12, 2019

I checked about standard-version. But I did not find the proper way to fix the past log.
Do you know the correct solution for this case?

@hiroppy
Copy link
Member

hiroppy commented Jun 12, 2019

ok, understood. We cannot generate this version in CAHNGELOG.md, because I rebased this commit. This is my mistake.

hiroppy
hiroppy previously approved these changes Jun 12, 2019
@hiroppy
Copy link
Member

hiroppy commented Jun 12, 2019

@numb86 Please fix your commit message. npm run commitlint

@numb86
Copy link
Contributor Author

numb86 commented Jun 12, 2019

I appreciate your gently advice.
I fixed it, so please review again.

@numb86
Copy link
Contributor Author

numb86 commented Jun 13, 2019

Of course I know that the test has failed.
But, I cannot understand why only Windows node-10 fails. In the first place, why edit CHANGELOG.md only and fail...
Is there anything I can do for resolve?

@alexander-akait
Copy link
Member

alexander-akait commented Jun 13, 2019

Random CI fail

@numb86
Copy link
Contributor Author

numb86 commented Jun 13, 2019

I see. Thanks!

@hiroppy
Copy link
Member

hiroppy commented Jun 13, 2019

Thanks!

@hiroppy hiroppy merged commit 8481205 into webpack:master Jun 13, 2019
@numb86 numb86 deleted the fix-change-log branch June 13, 2019 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants