refactor: server (part 2) #1849
Conversation
| const updateCompiler = require('./utils/updateCompiler'); | ||
| const createLogger = require('./utils/createLogger'); | ||
| const createCertificate = require('./utils/createCertificate'); | ||
| const getCertificate = require('./utils/getCertificate'); | ||
| const routes = require('./utils/routes'); |
There was a problem hiding this comment.
Fix order (eslint rule)
| return fs.readFileSync(certificatePath); | ||
| } | ||
|
|
||
| module.exports = getCertificate; |
| options.sockPath | ||
| ? options.sockPath.replace(/^\/|\/$/g, '') | ||
| this.options.sockPath | ||
| ? this.options.sockPath.replace(/^\/|\/$/g, '') |
There was a problem hiding this comment.
Now we should use this.options.<option> instead this.<option> because it is very uncomfortable and require extra code like: this.clientOverlay = options.clientOverlay so we should remove them in future major release
alexander-akait
force-pushed
the
refactor-server-part-2
branch
from
1d45a52 to
a33d0e4
Compare
Codecov Report
@@ Coverage Diff @@
## master #1849 +/- ##
==========================================
+ Coverage 89.22% 89.31% +0.08%
==========================================
Files 10 11 +1
Lines 622 627 +5
Branches 187 187
==========================================
+ Hits 555 560 +5
Misses 55 55
Partials 12 12
Continue to review full report at Codecov.
|
|
Feel free to feedback |
|
hmm... sorry but I can not understand that you can not wait 2 hours for the review... |
|
@hiroppy sorry, i think you still on vacation and unavaliable |
|
@hiroppy Feel free to any feedback and we fix it in next refactor PR |
For Bugs and Features; did you add new tests?
No need
Motivation / Use-Case
Refactor
Breaking Changes
No
Additional Info
No