fix(server): don't ignore node_modules by default #1970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/ContentBase.test.js
Outdated
| expect(folderWatched).toEqual(false); | ||
| done(); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
I this we should rewrite test to check what we watch node_modules (to avoid future regressions)
alexander-akait
requested changes
Jun 5, 2019
Codecov Report
@@ Coverage Diff @@
## master #1970 +/- ##
==========================================
- Coverage 92.47% 92.47% -0.01%
==========================================
Files 28 28
Lines 1077 1076 -1
Branches 322 322
==========================================
- Hits 996 995 -1
Misses 77 77
Partials 4 4
Continue to review full report at Codecov.
|
alexander-akait
approved these changes
Jun 5, 2019
hiroppy
changed the title
This was referenced Dec 14, 2019
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
yes
Motivation / Use-Case
fixes #1934
Breaking Changes
yes
Additional Info