-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[email protected] ignores changes in node_modules #1934
Comments
Do you resolve if you add |
Yup this solved the issue. Thank you. |
I have seen the issue #1781. However, the motivation behind this default exclusion is not very clear to me. Can you please elaborate? I am little bit concerned about any pitfalls of watching the changes in |
@Sayan751 watching node_modules is overhead in many cases and can throw error in some cases because node_modules can have many files Why you need watch node_modules? |
@evilebottnawi I see your point. I think it is a specific requirement for the workflow I follow. I use Aurelia for the web app development. And there lies small limitation of loading symlinked files correctly. That's why I use a small watch script to deploy the I am using this workflow for quite a sometime now. That's why when it broke after a minor update of webpack-dev-server, I was bit surprised. |
Thanks for answer we think about it in near future, you can have solution right now |
I'd like to second this bug, and make some suggestions. Personally I've used the With that being said, I think a large part of this problem is documentation. Despite the default being changed and changing behavior that's been around for quite a while, it's not mentioned in the 3.4.0 release notes, or even in the documentation for watchOptions.ignored. Since this is a relatively new change, it's not easy to Google to find out the answer. I understand the point of the change, and it seems like a positive one, but I think it would be great if the change and workaround could be put into the documentation of |
@Garethp Thanks for feedback, we will do this in future |
/cc @hiroppy what do you think about revert this commit? |
My answer is #1794 (comment). I think we should revert this... |
@hiroppy yes, let's do it |
As mentioned on the commit, I think resolving symlinks before excluding |
When i use yarn link and changed the files with symlinks , the webpack compiled successfully , but get a message shown '[WDS] Nothing changed' . That's why?When i change the symlinks to true, will get an error 'exports is not defined'. My config look like this:
|
Code
Expected Behavior
When any changes occur in the
node_modules
,webpack-dev-server
should trigger a new build.Actual Behavior
It is not happening after I upgraded to the latest
[email protected]
. With the earler version of3.3.1
it was working perfectly. If the fix is non-trivial, are there better workarounds rather than pinning the version?For Bugs; How can we reproduce the behavior?
I have created the repo https://github.com/Sayan751/webpack-reloading-issue to demonstrate this problem. The steps to reproduce the problem is detailed there.
For Features; What is the motivation and/or use-case for the feature?
The text was updated successfully, but these errors were encountered: