fix(schema): allow the output filename to be a {Function} (#1409)

webpack · Aug 22, 2018 · e2220c4 · e2220c4
1 parent 807c846
commit e2220c4
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/lib/optionsSchema.json b/lib/optionsSchema.json
@@ -36,6 +36,9 @@
         },
         {
           "type": "string"
+        },
+        {
+          "instanceof": "Function"
         }
       ]
     },

diff --git a/test/Validation.test.js b/test/Validation.test.js
@@ -70,6 +70,18 @@ describe('Validation', () => {
     });
   });
 
+  describe('filename', () => {
+    it('should allow filename to be a function', () => {
+      try {
+        // eslint-disable-next-line no-new
+        new Server(compiler, { filename: () => {} });
+      } catch (e) {
+        if (!(e instanceof OptionsValidationError)) { throw e; }
+        throw new Error("Validation failed and it shouldn't");
+      }
+    });
+  });
+
   describe('checkHost', () => {
     it('should always allow any host if options.disableHostCheck is set', () => {
       const options = {
-Original file line number
+Diff line change
@@ Expand Up / @@ -36,6 +36,9 @@ @@
             },
             {
               "type": "string"
+            },
+            {
+              "instanceof": "Function"
             }
           ]
         },
@@ Expand Down @@