fix(server): ignore stats objects that are empty

webpack · Jun 30, 2020 · 3319b0b · 3319b0b
1 parent 80a34c1
commit 3319b0b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/lib/utils/getStatsOption.js b/lib/utils/getStatsOption.js
@@ -1,8 +1,14 @@
 'use strict';
 
 function getStatsOption(configArr) {
+  const isEmptyObject = (val) =>
+    typeof val === 'object' && Object.keys(val).length === 0;
+
+  // in webpack@4 stats will not be defined if not provided,
+  // but in webpack@5 it will be an empty object
   const statsConfig = configArr.find(
-    (conf) => typeof conf === 'object' && conf.stats
+    (conf) =>
+      typeof conf === 'object' && conf.stats && !isEmptyObject(conf.stats)
   );
   return statsConfig ? statsConfig.stats : {};
 }

diff --git a/test/server/utils/getStatsOption.test.js b/test/server/utils/getStatsOption.test.js
@@ -69,6 +69,9 @@ describe('getStatsOption', () => {
       {
         entry: './index.js',
       },
+      {
+        stats: {},
+      },
       {
         stats: 'errors-only',
       },
-Original file line number
+Diff line change
@@ Expand Up / @@ -69,6 +69,9 @@ describe('getStatsOption', () => { @@
           {
             entry: './index.js',
           },
+          {
+            stats: {},
+          },
           {
             stats: 'errors-only',
           },
@@ Expand Down @@