BREAKING CHANGE: remove CLI default flag values for webpack-cli serve (…

…#2659)
webpack · Aug 22, 2020 · 289a98f · 289a98f
1 parent 86140c5
commit 289a98f
Show file tree

Hide file tree

Showing 5 changed files with 74 additions and 5 deletions.
diff --git a/bin/cli-flags.js b/bin/cli-flags.js
@@ -17,7 +17,6 @@ module.exports = {
     {
       name: 'live-reload',
       type: Boolean,
-      defaultValue: true,
       describe: 'Enables/Disables live reloading on changing files',
     },
     {
@@ -57,12 +56,12 @@ module.exports = {
       name: 'open-page',
       type: String,
       describe: 'Open default browser with the specified page',
+      multiple: true,
     },
     {
       name: 'client-logging',
       type: String,
       group: DISPLAY_GROUP,
-      defaultValue: 'info',
       describe:
         'Log level in the browser (none, error, warn, info, log, verbose)',
     },

diff --git a/bin/options.js b/bin/options.js
@@ -15,7 +15,6 @@ const options = {
   'live-reload': {
     type: 'boolean',
     describe: 'Enables/Disables live reloading on changing files',
-    default: true,
   },
   profile: {
     type: 'boolean',
@@ -56,7 +55,6 @@ const options = {
   'client-logging': {
     type: 'string',
     group: DISPLAY_GROUP,
-    default: 'info',
     describe:
       'Log level in the browser (none, error, warn, info, log, verbose)',
   },

diff --git a/client-src/default/utils/log.js b/client-src/default/utils/log.js
@@ -3,6 +3,8 @@
 const log = require('webpack/lib/logging/runtime');
 
 const name = 'webpack-dev-server';
+// default level is set on the client side, so it does not need
+// to be set by the CLI or API
 const defaultLevel = 'info';
 
 function setLogLevel(level) {

diff --git a/lib/utils/createConfig.js b/lib/utils/createConfig.js
@@ -14,10 +14,16 @@ function createConfig(config, argv, { port }) {
     options.bonjour = true;
   }
 
-  if (argv.host && (argv.host !== 'localhost' || !options.host)) {
+  // CLI args host takes precedence over devServer host
+  if (argv.host) {
     options.host = argv.host;
   }
 
+  // host defaults to localhost for CLI if none is provided
+  if (!options.host) {
+    options.host = 'localhost';
+  }
+
   if (argv.allowedHosts) {
     options.allowedHosts = argv.allowedHosts.split(',');
   }