fix(middleware): change how mime type option is handled #670
Conversation
Codecov Report
@@ Coverage Diff @@
## master #670 +/- ##
=======================================
Coverage 99.11% 99.11%
=======================================
Files 8 8
Lines 227 227
Branches 70 70
=======================================
Hits 225 225
Misses 2 2
Continue to review full report at Codecov.
|
| content = handleRangeHeaders(content, req, res); | ||
| // Content-Type and headers need to be set before checking if | ||
| // the file is in the outputFileSystem, as these things should be | ||
| // applied to all files that are being served |
There was a problem hiding this comment.
correct me if this approach is incorrect, but it seems that headers and content types need to be applied before rejecting a file that is not in the outputFileSystem. This is because files/routes served by webpack-dev-server like localhost:8080/main, or files that are in the user's directory and are being served, are not in the middleware filesystem but should still have the headers and content types applied to them. That is what the previous behavior was. But let me know if this was an intentional breaking change.
There was a problem hiding this comment.
Yes, looks like regression
|
/cc @hiroppy |
|
@Loonride should we do patch release? Or we have more regressions? |
@evilebottnawi Not yet, there still may be more that needs to be done. Still working through integrating it on the webpack-dev-server side |
|
👍 |
|
@evilebottnawi I think it is good now for a patch release |
This PR contains a:
Motivation / Use-Case
I think that the
mimeTypeoption should take priority over existing, known mime types. Otherwise, specifying amimeTypefor something like html or js will have no effect.Breaking Changes
Change of mimeType option priority with existing mime types
Additional Info