-
-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(init): fixes config resolution on generating new configuration #977
Conversation
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
2cf7d96
to
0d6fe14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you rebase against next
?
Sure |
139b75f
to
72bb694
Compare
@pranshuchittora Thanks for your update. I labeled the Pull Request so reviewers will review it again. @evenstensberg Please review the new changes. |
72bb694
to
44fa20c
Compare
Prettier config in the next branch.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
fixes entry point issues in the newly generated webpack config
Closes #976
What kind of change does this PR introduce?
Bugfix
Did you add tests for your changes?
Nopes
If relevant, did you update the documentation?
Nopes
Summary
While generating new config I am surprised that the generated webpack.config.js doesn't have an entry point.