Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(init): fixes config resolution on generating new configuration #977

Merged
merged 1 commit into from
Aug 14, 2019

Conversation

pranshuchittora
Copy link
Member

fixes entry point issues in the newly generated webpack config
Closes #976

What kind of change does this PR introduce?
Bugfix

Did you add tests for your changes?
Nopes
If relevant, did you update the documentation?
Nopes
Summary
While generating new config I am surprised that the generated webpack.config.js doesn't have an entry point.

@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rebase against next ?

@pranshuchittora
Copy link
Member Author

Could you rebase against next ?

Sure

@webpack-bot
Copy link

@pranshuchittora Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@evenstensberg Please review the new changes.

@pranshuchittora
Copy link
Member Author

Prettier config in the next branch.

   1   │ {
   2   │     "singleQuote": true,
   3   │     "trailingComma": "all"
   4   │ }

Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞[init]: entry point does not appears in newly generated config
3 participants