Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): throws err when no args passed #862

Merged
merged 15 commits into from
Jun 1, 2019
Merged

fix(cli): throws err when no args passed #862

Changes from 10 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
2250af0
fix(cli): error when no webpack and args found
pranshuchittora Apr 26, 2019
ff263f9
chore(cli): fixes code indentation
pranshuchittora Apr 26, 2019
cc64955
fix(cli): improves error handling with args
pranshuchittora Apr 26, 2019
a3ce273
fix(cli): shows error message based on package manager
pranshuchittora Apr 27, 2019
8d1adfe
Merge branch 'master' of github.com:webpack/webpack-cli into cli-blan…
pranshuchittora May 4, 2019
a9bc0bd
fix(cli): err when no args passed, refactored nested conditional blocks
pranshuchittora May 14, 2019
cfc0117
fix(ci): fixes linting error in ci
pranshuchittora May 14, 2019
3a034bf
Merge branch 'master' of github.com:webpack/webpack-cli into cli-blan…
pranshuchittora May 22, 2019
62e3c9e
Merge branch 'master' of github.com:webpack/webpack-cli into cli-blan…
pranshuchittora May 30, 2019
869024f
fix(cli): sets stack trace limit
pranshuchittora May 30, 2019
7d31321
fix(cli): removes func return in catch instance
pranshuchittora May 30, 2019
3d67892
Merge branch 'master' of github.com:webpack/webpack-cli into cli-blan…
pranshuchittora May 31, 2019
ac5a53f
fix(cli): removes the comment before err handling block
pranshuchittora May 31, 2019
b5e1913
fix(cli): updates err message
pranshuchittora Jun 1, 2019
9f1deb2
chore(cli): fixes linting err
pranshuchittora Jun 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 18 additions & 7 deletions bin/cli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,22 @@ For more information, see https://webpack.js.org/api/cli/.`);
try {
options = require("./utils/convert-argv")(argv);
} catch (err) {
// When webpack is not installed and no args passed to the CLI
pranshuchittora marked this conversation as resolved.
Show resolved Hide resolved
if (err.code === "MODULE_NOT_FOUND") {
let errorMessage =
"\n\u001b[31mwebpack not found, \u001b[33mplease install webpack using\n\t\u001b[32mnpm install --save-dev webpack\n";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

webpack not installed, consider installing it using npm install --save-dev webpack

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation seems weird here, you don't need different color schemes for the not found part, the please install part and the installation text. Two colors is sufficient, one for the error stack and one for the npm save

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


if (process.env.npm_execpath !== undefined && process.env.npm_execpath.includes("yarn")) {
errorMessage =
"\n\u001b[31mwebpack not found, \u001b[33mplease install webpack using\n\t\u001b[32myarn add webpack --dev\n";
}

console.error(errorMessage);
Error.stackTraceLimit = 1;
process.exitCode = 1;
return;
evenstensberg marked this conversation as resolved.
Show resolved Hide resolved
evenstensberg marked this conversation as resolved.
Show resolved Hide resolved
evenstensberg marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is fine, as long as we're doing it in the scope of only MODULE_NOT_FOUND

}

if (err.name !== "ValidationError") {
throw err;
}
Expand Down Expand Up @@ -326,19 +342,14 @@ For more information, see https://webpack.js.org/api/cli/.`);
const SIX_DAYS = 518400000;
const now = new Date();
if (now.getDay() === MONDAY) {
const {
access,
constants,
statSync,
utimesSync,
} = require("fs");
const { access, constants, statSync, utimesSync } = require("fs");
const lastPrint = statSync(openCollectivePath).atime;
const lastPrintTS = new Date(lastPrint).getTime();
const timeSinceLastPrint = now.getTime() - lastPrintTS;
if (timeSinceLastPrint > SIX_DAYS) {
require(openCollectivePath);
// On windows we need to manually update the atime
access(openCollectivePath, constants.W_OK, (e) => {
access(openCollectivePath, constants.W_OK, e => {
if (!e) utimesSync(openCollectivePath, now, now);
});
}
Expand Down