fix: Remove workspaces key, as yarn workspaces is not in use #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this monorepo uses `lerna bootstrap` with `npm` as a dependency manager, so the "workspaces" key is not needed. fixes #479
|
|
evenstensberg
approved these changes
Jun 2, 2018
evenstensberg
changed the title
|
Thanks for sending this in 🎉 @AviVahl |
|
🎉 This PR is included in version 3.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Removes the
"workspaces"key from the main package.jsonDid you add tests for your changes?
Nope, as no functionality has changed
If relevant, did you update the documentation?
Not relevant.
Summary
this monorepo uses
lerna bootstrapwithnpmas a dependency manager, so the "workspaces" key is not used.fixes #479
Does this PR introduce a breaking change?
No.