chore: update commander.js to v12 #4315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snitin315
commented
Nov 4, 2024
| @@ -1703,11 +1703,9 @@ describe("CLI API", () => { | |||
| consoleSpy = jest.spyOn(global.console, "log"); | |||
| exitSpy = jest.spyOn(process, "exit").mockImplementation(() => {}); | |||
|
|
|||
| cli.program.option("--color [value]", "any color", "blue"); | |||
There was a problem hiding this comment.
Adding a duplicate option now throws an error, hence updating the test case to use an existing option.
anshumanv
approved these changes
Nov 4, 2024
| ], | ||
| [ | ||
| "[1mMade with ♥ by the webpack team[22m.", | ||
| "Made with ♥ by the webpack team.", |
There was a problem hiding this comment.
@snitin315 Why it was changed?
There was a problem hiding this comment.
@alexander-akait Test case was updated to use --mode instead of --color.
#4315 (comment)
snitin315
added a commit
that referenced
this pull request
Dec 17, 2024
alexander-akait
pushed a commit
that referenced
this pull request
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
deps
Did you add tests for your changes?
Updated existing tests
If relevant, did you update the documentation?
NA
Summary
addHelpCommandusage is deprecated, hence migrated to the newhelpCommandAPI.Does this PR introduce a breaking change?
No
Other information
No