Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: drop support for webpack-dev-server@v4 #4301

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented Oct 23, 2024

What kind of change does this PR introduce?
refactor

Did you add tests for your changes?
NA
If relevant, did you update the documentation?
No
Summary
Drop support for webpack-dev-server v4.

Does this PR introduce a breaking change?
Yes

Other information
No

@snitin315 snitin315 requested a review from a team as a code owner October 23, 2024 01:57
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need clean up serve code too

@snitin315
Copy link
Member Author

@alexander-akait Can you share what's v4 specific code in serve?

@alexander-akait
Copy link
Member

Looks like I was wrong (it was for version 3) and everything is fine

@snitin315 snitin315 merged commit 0807d47 into next Oct 23, 2024
43 checks passed
@snitin315 snitin315 deleted the rm-dev-server-4 branch October 23, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants