Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add Node.js v20 #3739

Merged
merged 5 commits into from
Jun 1, 2023
Merged

ci: add Node.js v20 #3739

merged 5 commits into from
Jun 1, 2023

Conversation

snitin315
Copy link
Member

What kind of change does this PR introduce?

Did you add tests for your changes?

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

Other information

@snitin315 snitin315 requested a review from a team as a code owner April 19, 2023 01:12
@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Merging #3739 (394d0cd) into master (6344b47) will decrease coverage by 32.80%.
The diff coverage is n/a.

❗ Current head 394d0cd differs from pull request most recent head 61e4072. Consider uploading reports for the commit 61e4072 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #3739       +/-   ##
===========================================
- Coverage   91.64%   58.84%   -32.80%     
===========================================
  Files          22        9       -13     
  Lines        1628     1198      -430     
  Branches      466      381       -85     
===========================================
- Hits         1492      705      -787     
- Misses        136      493      +357     

see 19 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6344b47...61e4072. Read the comment docs.

@alexander-akait
Copy link
Member

Hm, do we have deprecations output there?

@snitin315
Copy link
Member Author

I'll check this locally.

@alexander-akait
Copy link
Member

magic 🧙 locally all works perfectly

@snitin315
Copy link
Member Author

There is a bug report in v20 nodejs/node#47614. It may be related.

@alexander-akait
Copy link
Member

@snitin315 hm, I don't think, because it works locally using node v20 on ubuntu

@alexander-akait
Copy link
Member

Problem with nyc here... trying to solve it

@alexander-akait
Copy link
Member

Merging #3739 (394d0cd) into master (6344b47) will decrease coverage by 32.80%.

Not good...

@alexander-akait alexander-akait merged commit 1e9e946 into master Jun 1, 2023
@alexander-akait alexander-akait deleted the snitin315-patch-1 branch June 1, 2023 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants