-
-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(test): updated tests file names #324
Conversation
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually we approve both, but okay 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also clean *.spec.js
from .npmignore?
@ev1stensberg do we? All the file names are |
@dhruvdutt why do I have to remove |
Because there would be no files with |
I can do it! But first I'd like to know @ev1stensberg point of you. |
Keep |
What kind of change does this PR introduce?
Chore, renamed test files
Did you add tests for your changes?
No
If relevant, did you update the documentation?
No
Summary
Changed test files from
*.spec.js
to*.test.js
Does this PR introduce a breaking change?
It shouldn't, although locally I had some failing test (not these ones) and I couldn't understand why
Other information