Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add pnpm as binary in info #3072

Closed
wants to merge 1 commit into from
Closed

Conversation

rishabh3112
Copy link
Member

What kind of change does this PR introduce?
chore / feat

Did you add tests for your changes?
WIP

If relevant, did you update the documentation?
N/A

Summary
Added pnpm as required binary.
Although pnpm isn't supported in envinfo, still this PR has required use case.

Does this PR introduce a breaking change?
Nope

Other information

@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #3072 (39dd422) into master (754615b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3072   +/-   ##
=======================================
  Coverage   94.86%   94.86%           
=======================================
  Files          22       22           
  Lines        1615     1615           
  Branches      480      480           
=======================================
  Hits         1532     1532           
  Misses         83       83           
Impacted Files Coverage Δ
packages/info/src/index.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 754615b...39dd422. Read the comment docs.

@rishabh3112
Copy link
Member Author

rishabh3112 commented Jan 5, 2022

Tasks

Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm meanwhile here, but not RTM (ready to merge)

@rishabh3112
Copy link
Member Author

rishabh3112 commented Mar 31, 2022

@webpack/cli-team Made a friendly ping on the issue at envinfo. Lets see...

@rishabh3112
Copy link
Member Author

Update: Created PR at tabrindle/envinfo#224

@rishabh3112
Copy link
Member Author

The PR on envinfo has been inactive for a while, and main maintainer is inactive for over a long time given last publish on npm was over a year ago.

image

I guess we can patch it into a fork and deploy it, wdyt @alexander-akait? if yes I will do that.

@rishabh3112
Copy link
Member Author

rishabh3112 commented May 14, 2022

@webpack/cli-team One last try I have pinged him on PR, lets see.

@rishabh3112
Copy link
Member Author

Got a review there, would be working on that now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants