-
-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add pnpm as binary in info #3072
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3072 +/- ##
=======================================
Coverage 94.86% 94.86%
=======================================
Files 22 22
Lines 1615 1615
Branches 480 480
=======================================
Hits 1532 1532
Misses 83 83
Continue to review full report at Codecov.
|
Tasks
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm meanwhile here, but not RTM (ready to merge)
@webpack/cli-team Made a friendly ping on the issue at |
Update: Created PR at tabrindle/envinfo#224 |
The PR on I guess we can patch it into a fork and deploy it, wdyt @alexander-akait? if yes I will do that. |
@webpack/cli-team One last try I have pinged him on PR, lets see. |
Got a review there, would be working on that now. |
What kind of change does this PR introduce?
chore / feat
Did you add tests for your changes?
WIP
If relevant, did you update the documentation?
N/A
Summary
Added pnpm as required binary.
Although pnpm isn't supported in envinfo, still this PR has required use case.
Does this PR introduce a breaking change?
Nope
Other information