-
-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sharabale configs #2868
feat: sharabale configs #2868
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2868 +/- ##
==========================================
+ Coverage 94.95% 94.99% +0.04%
==========================================
Files 31 31
Lines 1704 1719 +15
Branches 484 488 +4
==========================================
+ Hits 1618 1633 +15
Misses 86 86
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add tests with --merge
too
I am also implementing |
Yep, it is great idea |
506f46b
to
4f5de57
Compare
|
||
await this.resolveConfig(newOptions); | ||
} | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not use webpack-merge
logic here? it is working good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will also need to load the extended configurations, here we have only paths
for extended configurations and not their options
.
Or am I missing something here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally --extends
means --config=webpack.config.js --config=webpack.other.config.js --merge
, so I think we already have logic for this, for the next major release we will change logic for multiple --config
https://github.com/webpack/webpack-cli/blob/master/packages/webpack-cli/lib/webpack-cli.js#L1619, I think we will throw an error on two and more config options without --merge
, but we can reuse this logic for --extends
, --extends
like syntax sugar, also do not forget --extends
in CLI should override extends
on webpack.config.js
(I think eslint works the same, but need check)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will refactor 👍🏻 .
4993cab
to
8e352fa
Compare
Fixed #3738 |
What kind of change does this PR introduce?
FEATURE
Did you add tests for your changes?
yes, more tests WIP
If relevant, did you update the documentation?
WIP
Summary
Fixes #2748
Does this PR introduce a breaking change?
No
Other information
WIP in covering more edge cases with multiple nested configs and multi compiler mode.