-
-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc(yargs): add description for module-bind-* args #286
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you point to the documentation for this? Gotta double check
@ev1stensberg Updated the PR description. Here's the link again. |
Can you rebase the commit to match the spec? We'll need a feat flag, but it hasn't been implemented yet |
081722b
to
2609f78
Compare
@dhruvdutt Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ematipico Please review the new changes. |
2609f78
to
2d2ccf3
Compare
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
@ev1stensberg Sorry, I didn't get what you meant here.
Where do we need to implement flag? Is it something related to |
Lgtm |
@ev1stensberg Should I setup/implement feat flag inside I think we can just rename |
yep, up for grabs. As well as a |
What kind of change does this PR introduce?
Enhancement
Summary
Add missing description for
module-bind-post
andmodule-bind-pre
argumentsDocs link for the same.
Does this PR introduce a breaking change?
No