Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configtest validate default configuration #2354

Merged
merged 2 commits into from
Jan 15, 2021

Conversation

alexander-akait
Copy link
Member

What kind of change does this PR introduce?

feature

Did you add tests for your changes?

Yes

If relevant, did you update the documentation?

Yes

Summary

configtest wroks without config-path (loaded default webpack.config.[ext])

Does this PR introduce a breaking change?

No

Other information

No

anshumanv
anshumanv previously approved these changes Jan 14, 2021
Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need CI fix

@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #2354 (39dd318) into master (38869d2) will increase coverage by 0.20%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2354      +/-   ##
==========================================
+ Coverage   69.27%   69.47%   +0.20%     
==========================================
  Files          47       47              
  Lines        2099     2110      +11     
  Branches      536      541       +5     
==========================================
+ Hits         1454     1466      +12     
+ Misses        645      644       -1     
Impacted Files Coverage Δ
packages/configtest/src/index.ts 96.66% <100.00%> (+1.92%) ⬆️
packages/webpack-cli/lib/webpack-cli.js 90.85% <100.00%> (ø)
packages/webpack-cli/lib/utils/logger.js 88.88% <0.00%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38869d2...39dd318. Read the comment docs.

@alexander-akait alexander-akait merged commit 487691a into master Jan 15, 2021
@alexander-akait alexander-akait deleted the feat-allow-configtest-test-default-config branch January 15, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants