Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using bundleCommand instead of createCompiler in webpack-cli/serve #2268

Closed
wants to merge 1 commit into from

Conversation

superhit0
Copy link

@superhit0 superhit0 commented Dec 28, 2020

What kind of change does this PR introduce?

bugfix

Did you add tests for your changes?
Need help as this is my first time contributing to webpack

If relevant, did you update the documentation?
N/A

Summary

  • The serve command uses webpack-cli but it creates a compiler without options which gives a deprecation warning on webpack@5, this one uses changes the use to bundleCommand, which wraps the callabck inside it

This results in this error - Issue#1918 when we run

  • npx webpack-dev-server --watch

Does this PR introduce a breaking change?
No

Other information
@alexander-akait

@superhit0 superhit0 requested a review from a team as a code owner December 28, 2020 10:26
@superhit0 superhit0 force-pushed the abhi-fix-serve branch 2 times, most recently from 34c2f76 to 78db679 Compare December 28, 2020 10:48
@snitin315
Copy link
Member

npx webpack-dev-server --watch

this is not the right way anymore. webpack-cli serve should be used to invoke webpack-dev-server.

@alexander-akait
Copy link
Member

Remove --watch from options, expected

@alexander-akait
Copy link
Member

It is invalid fix and break serve command

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants