Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ci lint #2208

Merged
merged 1 commit into from
Dec 7, 2020
Merged

fix: ci lint #2208

merged 1 commit into from
Dec 7, 2020

Conversation

anshumanv
Copy link
Member

What kind of change does this PR introduce?

CI lint is failing

Did you add tests for your changes?
yep

If relevant, did you update the documentation?
no

Summary
no

Does this PR introduce a breaking change?
no

Other information
no

@anshumanv anshumanv requested a review from a team as a code owner December 7, 2020 15:18
@anshumanv
Copy link
Member Author

introduced in - #2172

@anshumanv anshumanv mentioned this pull request Dec 7, 2020
Merged
snitin315
snitin315 approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@anshumanv
Copy link
Member Author

Lint passed, I think we can merge and make room for other jobs 😄

@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #2208 (ff7e400) into master (53ed926) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2208   +/-   ##
=======================================
  Coverage   65.94%   65.94%           
=======================================
  Files          70       70           
  Lines        2352     2352           
  Branches      523      523           
=======================================
  Hits         1551     1551           
  Misses        801      801

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53ed926...ff7e400. Read the comment docs.

@alexander-akait alexander-akait merged commit 5872d35 into webpack:master Dec 7, 2020
@anshumanv anshumanv deleted the ci-lint branch December 7, 2020 15:43
@anshumanv
Copy link
Member Author

cancelled remaining runs and master job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snitin315 snitin315 snitin315 approved these changes

@jamesgeorge007 jamesgeorge007 jamesgeorge007 approved these changes

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
PR: reviewed-approved PR: small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anshumanv @alexander-akait @jamesgeorge007 @snitin315 @webpack-bot