Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use compiler.apply for Progress Plugin #1772

Merged
merged 3 commits into from
Aug 27, 2020
Merged

Conversation

rishabh3112
Copy link
Member

What kind of change does this PR introduce?
Design Bug Fix

Did you add tests for your changes?
Yes

If relevant, did you update the documentation?
N/A

Summary
Using webpack's default handler for progress plugin instead of providing one in CLI.

Does this PR introduce a breaking change?
No

Other information
/cc @evilebottnawi

@evenstensberg evenstensberg changed the title fix: use default webpack handler for Progress Plugin fix: use compiler.apply for Progress Plugin Aug 27, 2020
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @webpack/cli-team

@webpack-bot
Copy link

@jamesgeorge007 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@anshumanv Please review the new changes.

@snitin315 snitin315 merged commit e8f2f20 into next Aug 27, 2020
@snitin315 snitin315 deleted the fix/progress-handler branch August 27, 2020 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants