Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support to spawn multiple compilers with different configs #1765

Merged
merged 9 commits into from
Aug 25, 2020
Merged

feat: add support to spawn multiple compilers with different configs #1765

merged 9 commits into from
Aug 25, 2020

Conversation

anshumanv
Copy link
Member

@anshumanv anshumanv commented Aug 21, 2020 •
edited
Loading

What kind of change does this PR introduce?

feat

Did you add tests for your changes?
yes

If relevant, did you update the documentation?
yes

Summary

  • Make config flag support multiple config
  • when multiple configs are supplied they are passed to the compiler as array webpack([{...}, {...}]) which spawn multiple compilers
  • In case of single config, resolved config object is passed directly

Does this PR introduce a breaking change?
No

Other information

@anshumanv
Copy link
Member Author

anshumanv commented Aug 21, 2020 •
edited
Loading

wip now

@anshumanv anshumanv marked this pull request as ready for review August 22, 2020 10:21
@anshumanv anshumanv requested a review from a team as a code owner August 22, 2020 10:21
@anshumanv anshumanv changed the title feat: add support for multi config feat: add support to spawn multiple compilers with different configs Aug 22, 2020
evenstensberg
evenstensberg previously approved these changes Aug 23, 2020
View reviewed changes
snitin315
snitin315 previously approved these changes Aug 24, 2020
View reviewed changes
rishabh3112
rishabh3112 previously approved these changes Aug 24, 2020
View reviewed changes
@webpack-bot
Copy link

@anshumanv Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@jamesgeorge007 Please review the new changes.

@anshumanv
Copy link
Member Author

/cc @webpack/cli-team

@alexander-akait
Copy link
Member

/cc @evenstensberg

@anshumanv
Copy link
Member Author

Merging, thanks for the feedback everyone! 💯

@anshumanv anshumanv merged commit c63ab29 into webpack:next Aug 25, 2020
@anshumanv anshumanv deleted the multi-config branch August 25, 2020 18:18
@anshumanv anshumanv mentioned this pull request Sep 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesgeorge007 jamesgeorge007 jamesgeorge007 left review comments

@snitin315 snitin315 snitin315 approved these changes

@evenstensberg evenstensberg evenstensberg approved these changes

@rishabh3112 rishabh3112 rishabh3112 approved these changes

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
PR: reviewed-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@anshumanv @webpack-bot @alexander-akait @rishabh3112 @evenstensberg @jamesgeorge007 @snitin315