Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: serve integration #1712

Merged
merged 25 commits into from
Aug 17, 2020
Merged

feat: serve integration #1712

merged 25 commits into from
Aug 17, 2020

Conversation

rishabh3112
Copy link
Member

What kind of change does this PR introduce?
Serve integration

Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
No
Summary
Integrated serve regardless some issues left to be addressed.

Does this PR introduce a breaking change?
No

Other information
@evilebottnawi 's comment #717 (comment)

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do some improvements to avoid npm/yarn/pnp problems with https://github.com/webpack/webpack-cli/blob/next/packages/serve/package.json#L17:

  1. Remove webpack-dev-server from peerDependencies
  2. "peerDependenciesMeta": { "webpack-dev-server": { "optional": true } }
  3. Add
let webpackDevServer;

try { 
  webpackDevServer = require.resolve('webpack-dev-server') 
} catch (error) {
  throw new Error(`You need to install `webpack-dev-server` for running `webpack server`.\n${error}`);
}

Maybe we should improve error message, feel free to do it

@webpack-bot
Copy link

@rishabh3112 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@evilebottnawi Please review the new changes.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One fix

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After open issues, feel free to merge when CI will be green

snitin315
snitin315 previously approved these changes Aug 13, 2020
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @webpack/cli-team need review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants