feat: import flags from webpack core [WIP] #1629
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imported flags from core
|
@snitin315 you can continue working on top, this is the very basic version, I'll continue collaborating on this as you go. 🚀 |
5 tasks
rishabh3112
requested changes
Jun 24, 2020
There was a problem hiding this comment.
@anshumanv I think as we already have #1630 in continuation to this work. We should close this to avoid confusion. If there is any use-case for letting it open, let me know :)
|
Yes, @snitin315 has already picked my commits from this PR, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature
Did you add tests for your changes?
Not yet
If relevant, did you update the documentation?
Not yet
Summary
Does this PR introduce a breaking change?
Shouldn't
Other information