fix(webpack-cli): verbose flag functionality #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snitin315
commented
May 16, 2020
snitin315
force-pushed
the
fix/verbose
branch
2 times, most recently
from
fae35b3
to
107ae2c
Compare
snitin315
force-pushed
the
fix/verbose
branch
4 times, most recently
from
e01fd20
to
1edf00f
Compare
snitin315
changed the title
|
/cc @rishabh3112 |
rishabh3112
requested changes
May 20, 2020
| const { run } = require('../utils/test-utils'); | ||
|
|
||
| describe('verbose flag', () => { | ||
| it('should accept --verbose', () => { |
There was a problem hiding this comment.
Need a better test here. i.e. we should test for lines in stdout that are found only in verbose stats.
There was a problem hiding this comment.
updated 👍, Please take a look.
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-approved
PR: reviewed-changes-requested
labels
|
@snitin315 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @rishabh3112 Please review the new changes. |
ryanclark
approved these changes
May 20, 2020
alexander-akait
approved these changes
May 20, 2020
anshumanv
approved these changes
May 21, 2020
This was referenced Jul 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
fixes verbose flag implementation.
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
NA
Summary
Fixes #1542
After
Does this PR introduce a breaking change?
No
Other information