fix(generators): fix and refactor entry util, add tests #1392
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
fix, refactor
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
N/A
Summary
The generators
entry
util was overly complicated and repetitive. One strange piece of logic in it was this:webpack-cli/packages/generators/src/utils/entry.ts
Line 38 in e232d0e
path.join(__dirname, 'index.js')
. However, allowing this functionality makes no sense given how the init generator will try to write a file using this path (not what this line executes to, but the actual string"path.join(__dirname, 'index.js')"
, since this would be what the user provided on command line - an unlikely scenario).I did the following:
src/index
then it will be adjusted to./src/index.js
. But if the user provides./src/index.js
, nothing is changedDoes this PR introduce a breaking change?
Yes, as mentioned above
Other information