Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Deps 'webpack' and 'uglifyjs-webpack-plugin' not installed when ... #136

Merged
merged 1 commit into from
May 12, 2017
Merged

Conversation

nilliams
Copy link
Contributor

... user answers yes to 'using ES2015?' (#135).

What kind of change does this PR introduce?
Bugfix

Did you add tests for your changes?
No (none in repo)

If relevant, did you update the documentation?
N/A

Summary
Fixes essential deps not being installed, when using webpack-cli init and answering 'yes' to 'Will you be using ES2015?'

Does this PR introduce a breaking change?
No

@jsf-clabot
Copy link

jsf-clabot commented May 12, 2017

CLA assistant check
All committers have signed the CLA.

@evenstensberg
Copy link
Member

Oh, sorry about that! Important fix, will merge by sunday!

@nilliams
Copy link
Contributor Author

No probs, thanks! 👍🏼

@evenstensberg evenstensberg self-requested a review May 12, 2017 16:59
Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evenstensberg evenstensberg merged commit 524f035 into webpack:master May 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants